Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should tooltips be using the Core tooltip API? #48

Closed
kirsty-hames opened this issue Aug 16, 2023 · 2 comments · Fixed by #49
Closed

Should tooltips be using the Core tooltip API? #48

kirsty-hames opened this issue Aug 16, 2023 · 2 comments · Fixed by #49
Assignees
@swashbuck
Labels
enhancement

Comments

@kirsty-hames
Copy link
Contributor

Does the plugin need updating to use the Core tooltip API instead?

Ref tooltip API implemented: adaptlearning/adapt-contrib-core#207
@oliverfoster
Copy link
Member

oliverfoster commented Aug 16, 2023 •
edited
Loading

yes please

@swashbuck
Copy link
Contributor

@kirsty-hames I can look at this as part of #41 ?

@swashbuck swashbuck mentioned this issue Aug 31, 2023
Merged
@swashbuck swashbuck self-assigned this Aug 31, 2023
@swashbuck swashbuck linked a pull request Feb 26, 2024 that will close this issue
Breaking: Update and modernize, simplify configuration (fixes #41 #48) #49
Merged
oliverfoster added a commit that referenced this issue Feb 27, 2024
@oliverfoster
Breaking: Update and modernize, simplify configuration (fixes #41 #48)
2663645
github-actions bot pushed a commit that referenced this issue Feb 27, 2024
@semantic-release-bot
Chore(release): 3.0.0 [skip ci]
d1bc41b 
# [3.0.0](v2.4.0...v3.0.0) (2024-02-27)

### Breaking

* Update and modernize, simplify configuration (fixes #41 #48) ([2663645](2663645)), closes [#41](#41) [#48](#48)

### onButtonClick

* Lookup model props instead of checking for CSS classes ([a3cb053](a3cb053))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: Update and modernize, simplify configuration (fixes #41 #48) cgkineo/adapt-pageNav
3 participants
@swashbuck @kirsty-hames @oliverfoster