Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen reader compatibility #9

Open
guywillis opened this issue Nov 21, 2024 · 4 comments
Open

Screen reader compatibility #9

guywillis opened this issue Nov 21, 2024 · 4 comments
Assignees
Labels

Comments

@guywillis
Copy link
Contributor

Subject of the issue

NVDA looks to have some compatibility issues with the issue/4 branch.

NVDA / Chrome

  • Does not seem to pick up the definition buttons properly when going through content. See attached for a visual read out
  • When closing a definitions notify pop up it does not seem to return you to where you left off. Mine seemed to push me to the end of the page.

Screenshot 2024-11-21 at 14 56 04

Your environment

  • Master

Expected behaviour

  • The button element is separated from the rest of the body content
  • Closing the notify returns the focus to the button element
@guywillis guywillis added the bug label Nov 21, 2024
@guywillis
Copy link
Contributor Author

What first appears to be a bug is actually the default configuration for NVDA. Inline interactive elements are read out alongside the text content, as seen in the screenshot. There is a prefixed label attached to a button element that is read out to inform the users that a button is present but the user is required to manually navigate to the interactive element. This can be achieved by using the tab key to navigate to the next interactive element.

The second issue raised is hard to judge whether it's an NVDA bug or bug in Adapt. If a user uses the NVDA keyboard shortcut b (which navigates the user to the next button element) and then presses enter to open the notify event, upon closing said notify the focus is at the end of the page. If a user were to use the NVDA keyboard shortcut tab (which navigates the user to the next interactive element), upon closing the notify the focus returns to the button element that triggered the notify event.

I can reliably replicate this not just with definitions but with the hotgraphic plugin too.

@oliverfoster
Copy link
Member

I'll have a look at the second point where the focus goes missing.

@oliverfoster oliverfoster self-assigned this Dec 2, 2024
@oliverfoster
Copy link
Member

oliverfoster commented Dec 2, 2024

I cannot replicate either with tab or b + esc or click to exit with chrome on nvda on windows 10.

image
image

I'll update both to see if I can replicate.

update: cannot replicate second issue at all with focus going missing, might be a mac problem?

@guywillis
Copy link
Contributor Author

guywillis commented Dec 2, 2024

My testing environment was Windows / Chrome via a Virtual Desktop. It's weirdly reliable using b but works fine with tab. I'm happy to chalk the issue up to the testing environment if you can't replicate natively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants