Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic feature to set any valid Undertow option #138

Open
bdw429s opened this issue Aug 4, 2018 · 3 comments
Open

Add generic feature to set any valid Undertow option #138

bdw429s opened this issue Aug 4, 2018 · 3 comments

Comments

@bdw429s
Copy link
Member

bdw429s commented Aug 4, 2018

Runwar has support for many of the undertow options, but it would also be handy to have a generic approach for any edge case options or new options that a user needs to tap into that we don't have first-class support for yet.

http://undertow.io/undertow-docs/undertow-docs-2.0.0/index.html#options

@denuno
Copy link
Member

denuno commented Aug 12, 2018

I'm thinking a xnioOptions="SOME_OPTION=2345,ANOTHER=woohoo" as the format, think that would work for everything?

On a semi-related note, I like JSON files to represent the data, so where we're storing lists (welcome files, and potentially this), I'd prefer to convert them to arrays, and store that in the JSON instead, just so we can eventually have a schema and verify things easier (and stuff like array.add(thing) over splitting/handling [trailing] commas, etc.). Just something to keep in mind, maybe for v5.

@bdw429s
Copy link
Member Author

bdw429s commented Aug 14, 2018

That format works ok so long as we won't have an equals sign or command in a setting name or value. Or, at least, have a way to escape them.

@bdw429s
Copy link
Member Author

bdw429s commented Aug 31, 2018

I've had the need for this come up several times recently. Ususally in regards to invalid URL chars that web servers like IIS let through but Undertow chokes on unless you set a special option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants