-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TOC current items highlighting #3148
Conversation
@cf-bottom jenkins |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/447/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-447/output/_site/ |
2b5d97e
to
7465521
Compare
@cf-bottom jenkins |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/448/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-448/output/_site/ |
7465521
to
b4333b1
Compare
@cf-bottom jenkins |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/449/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-449/output/_site/ |
b4333b1
to
2d449fd
Compare
@cf-bottom jenkins |
@aleksandrychev remember to backport to 3.21 and Alvaldi |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/450/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-450/output/_site/ |
2d449fd
to
87a7887
Compare
@cf-bottom jenkins |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/451/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-451/output/_site/ |
javascript_asset_tag does not support ES6 and throws errors Signed-off-by: Ihor Aleksandrychiev <[email protected]>
6bfe95b
to
8527ba1
Compare
@cf-bottom jenkins |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/452/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-452/output/_site/ |
Ticket: ENT-9758 Signed-off-by: Ihor Aleksandrychiev <[email protected]>
8527ba1
to
7a0b41f
Compare
@cf-bottom jenkins |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/453/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-453/output/_site/ |
@cf-bottom jenkins, please :) |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/455/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-455/output/_site/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks :)
Remember to bring over to Alvaldi docs. |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/464/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-464/output/_site/ |
@aleksandrychev Thanks for the work, 1 things I noticed seems not right in the new preview link, is the navigation table button doesn't react when I click on it (screen record 1) Screen.Recording.1.movnot sure if it is because of the preview build is not configure right or other reason, please check :) |
good catch! added change to preserve js functions names to the webpack |
@cf-bottom jenkins please |
c786101
to
fd5d511
Compare
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/467/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-467/output/_site/ |
@cf-bottom jenkins |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/468/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-468/output/_site/ |
@cf-bottom jenkins |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/470/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-470/output/_site/ |
…ibutes Signed-off-by: Ihor Aleksandrychiev <[email protected]>
a82ec08
to
2091824
Compare
@cf-bottom jenkins |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/472/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-472/output/_site/ |
I tried the latest preview link, the previous issue seems no longer exist, looks good to me! Thanks. |
@olehermanse please merge alvaldi PR - https://github.com/NorthernTechHQ/alvaldi-docs/pull/96 |
Ticket: ENT-9758