Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TOC current items highlighting #3148

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

aleksandrychev
Copy link
Contributor

Ticket: ENT-9758

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@olehermanse
Copy link
Member

@aleksandrychev remember to backport to 3.21 and Alvaldi

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

javascript_asset_tag does not support ES6 and throws errors

Signed-off-by: Ihor Aleksandrychiev <[email protected]>
@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

Ticket: ENT-9758
Signed-off-by: Ihor Aleksandrychiev <[email protected]>
@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@aleksandrychev aleksandrychev changed the title WIP: Added TOC current items highlighting Added TOC current items highlighting Dec 13, 2023
@olehermanse
Copy link
Member

@cf-bottom jenkins, please :)

Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks :)

@olehermanse
Copy link
Member

Remember to bring over to Alvaldi docs.

@olehermanse
Copy link
Member

@cf-bottom jenkins, please

@chiachenglu
Copy link
Contributor

@aleksandrychev Thanks for the work, 1 things I noticed seems not right in the new preview link, is the navigation table button doesn't react when I click on it (screen record 1)

Screen.Recording.1.mov

not sure if it is because of the preview build is not configure right or other reason, please check :)

@aleksandrychev
Copy link
Contributor Author

@aleksandrychev Thanks for the work, 1 things I noticed seems not right in the new preview link, is the navigation table button doesn't react when I click on it (screen record 1)

Screen.Recording.1.mov
not sure if it is because of the preview build is not configure right or other reason, please check :)

good catch! added change to preserve js functions names to the webpack

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins please

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@chiachenglu
Copy link
Contributor

I tried the latest preview link, the previous issue seems no longer exist, looks good to me! Thanks.

@aleksandrychev
Copy link
Contributor Author

@olehermanse olehermanse merged commit 3fd35e1 into cfengine:master Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants