-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker fixups #3125
Docker fixups #3125
Conversation
Installing redcarpet tried to pull in a newer version of execjs which wanted newer ruby. This simply makes sure that execjs is installed at our needed version first.
Still not fully working. Running
|
I modified main.sh swapping out references to ubuntu 18 with ubuntu 22 to match the dockerfile. I then rebuilt the docker container and I was then able to |
I am then able to load the site in firefox from the local files. CSS and JS don't load because of wrong path issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look relatively harmless and if they improve the situation, cool.
@cf-bottom jenkins, please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/421/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-421/output/_site/ |
Alrighty, this seems to work. So, merging. |
I tried the docker build and failed. These changes are my quick try for improvement.