CFE-4053: Fixed bug where default:sys.fqhost contained many spaces #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug where `default:sys.fqhost` contained many spaces when domain is set in body common control. Ticket: CFE-4053 Changelog: Commit Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
added
the
cherry-pick?
vpodzime
reviewed
Jun 5, 2024
| if => strcmp( "$(sys.fqhost)", "$(sys.uqhost).cfengine.com" ); | ||
|
|
||
| "$(this.promise_filename) FAIL" | ||
| unless => strcmp( "$(sys.fqhost)", "$(sys.uqhost).cfengine.com" ); |
There was a problem hiding this comment.
I don't expect this to work on my machine. And many other machines...
There was a problem hiding this comment.
Because I don't think my machine has $(sys.uqhost).cfengine.com as its FQDN. Or are we ensuring that somewhere?
There was a problem hiding this comment.
Aren't we doing that with domain => "cfengine.com" in body common control?
There was a problem hiding this comment.
Oh! I guess we are! I didn't see that. Or rather, I didn't even know it was possible. 😅
craigcomstock
approved these changes
Jun 5, 2024
vpodzime
removed
the
cherry-pick?
olehermanse
reviewed
Jun 5, 2024
| EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "domain", | ||
| VDOMAIN, CF_DATA_TYPE_STRING, | ||
| "source=agent"); | ||
| EvalContextClassPutHard(ctx, VDOMAIN, "source=agent"); | ||
|
|
||
| int ret = snprintf(VFQNAME, CF_MAXVARSIZE, "%s.%s", VUQNAME, VDOMAIN); |
There was a problem hiding this comment.
@larsewi In this case, the diff is rather big, but the important difference is the change from %511s.%511s to %s.%s. I would've explained this in the commit (as you did in the ticket).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where
default:sys.fqhostcontained many spaces when domain is set in body common control.Ticket: CFE-4053
Changelog: Commit
Signed-off-by: Lars Erik Wik [email protected]