Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-4244: Add the function name to the result cache key #5317

Merged
merged 2 commits into from
Sep 15, 2023
Merged

CFE-4244: Add the function name to the result cache key #5317

merged 2 commits into from
Sep 15, 2023

Commits on Sep 13, 2023

  1. Added the function name to the result cache key 

    The function cache only used the args values, which in some cases could
lead to mixing results from different functions with the same arguments.

Ticket: CFE-4244
Changelog: Cashed policy function results now take into account number of arguments and function name.
Signed-off-by: Lars Erik Wik <[email protected]>
Co-authored-by: Alexis Mousset <[email protected]>
    @amousset @larsewi
    amousset authored and larsewi committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    29e60a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Moved asserts to top of EvalContextFunctionCache functions 

    Two reasons for this:
 1. CONTRIBUTING.md says to do this at the top
 2. the `ctx` argument was actually used before the assert

Ticket: None
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
    @larsewi
    larsewi committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    eec9776 View commit details
    Browse the repository at this point in the history