ENT-10944: cfbs build/download: Added validation and error messages #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added many helpful error messages to tell the user what is wrong with their cfbs.json (why they cannot run cfbs build or cfbs download). The config must have a build field, with a list of modules, each module must have a name, a non-empty list of steps, each step must be a non-empty string, etc. Ticket: ENT-10944 Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
oleorhagen
approved these changes
Nov 29, 2023
larsewi
approved these changes
Nov 29, 2023
|
@larsewi not in the current state. This validation is for the things needed for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added many helpful error messages to tell the user what
is wrong with their cfbs.json (why they cannot run cfbs
build or cfbs download).
The config must have a build field, with a list of modules,
each module must have a name, a non-empty list of steps,
each step must be a non-empty string, etc.
Ticket: ENT-10944