Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-8980: The prompt for adding all modules now has yes/y/no/n options, like the other prompts #161

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

danielskinstad
Copy link
Contributor

Changed hardcoded print of [y/N] to [yes/y/NO/n] using helper function to be consistent

Ticket: ENT-8980

Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🚀

Before merging please:

Also I would recommend not committing directly to you master branch, as it can make some things a little bit more complicated for you down the line. Instead create a new branch to work on.

To do all the fixes above I would recommend getting to know how to do an interactive rebase (see https://github.com/cfengine/core/blob/master/CONTRIBUTING.md#interactive-rebase)

Lastly, don't hesitate to bombard me with questions!

cfbs/prompts.py Show resolved Hide resolved
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good, the commits we can improve. In addition to the things mentioned by @larsewi, it also looks like you have committed as "cfbs" - please put your name and email as author / committer when you make commits.

Furthermore, it would be better if the PR title / commit title focused on what is the impact to a user. Here is my suggestion:

The prompt for adding all modules now has yes/y/no/n options, like the other prompts

Feel free to ask me for help if you are unsure about how to edit commits :)

Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
@danielskinstad danielskinstad changed the title Changed hardcoded print of [y/N] to [yes/y/NO/n] using helper function to be consistent ENT-8980 Changed hardcoded print of [y/N] to [yes/y/NO/n] using helper function to be consistent Nov 8, 2023
…e other prompts

Ticket: ENT-8980

Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
@danielskinstad danielskinstad changed the title ENT-8980 Changed hardcoded print of [y/N] to [yes/y/NO/n] using helper function to be consistent ENT-8980 The prompt for adding all modules now has yes/y/no/n options, like the other prompts Nov 8, 2023
@olehermanse olehermanse changed the title ENT-8980 The prompt for adding all modules now has yes/y/no/n options, like the other prompts ENT-8980: The prompt for adding all modules now has yes/y/no/n options, like the other prompts Nov 8, 2023
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks! 🚀

@olehermanse olehermanse merged commit 5862616 into cfengine:master Nov 8, 2023
7 checks passed
@larsewi
Copy link
Contributor

larsewi commented Nov 8, 2023

Congrats 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants