-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-8980: The prompt for adding all modules now has yes/y/no/n options, like the other prompts #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🚀
Before merging please:
- put different unrelated changes in their own commits
- format code with the black formatter for python
- sign your commits using
git commit -s
(see https://github.com/cfengine/core/blob/master/CONTRIBUTING.md#commit-message-example) - add the ticket number to the PR Title (see https://github.com/cfengine/core/blob/master/CONTRIBUTING.md#pull-request-title-and-description)
Also I would recommend not committing directly to you master branch, as it can make some things a little bit more complicated for you down the line. Instead create a new branch to work on.
To do all the fixes above I would recommend getting to know how to do an interactive rebase (see https://github.com/cfengine/core/blob/master/CONTRIBUTING.md#interactive-rebase)
Lastly, don't hesitate to bombard me with questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good, the commits we can improve. In addition to the things mentioned by @larsewi, it also looks like you have committed as "cfbs" - please put your name and email as author / committer when you make commits.
Furthermore, it would be better if the PR title / commit title focused on what is the impact to a user. Here is my suggestion:
The prompt for adding all modules now has yes/y/no/n options, like the other prompts
Feel free to ask me for help if you are unsure about how to edit commits :)
Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
…e other prompts Ticket: ENT-8980 Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks! 🚀
Congrats 🚀 |
Changed hardcoded print of [y/N] to [yes/y/NO/n] using helper function to be consistent
Ticket: ENT-8980