Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrections to units_metadata text #496

Closed
JonathanGregory opened this issue Dec 4, 2023 · 2 comments · Fixed by #495
Closed

corrections to units_metadata text #496

JonathanGregory opened this issue Dec 4, 2023 · 2 comments · Fixed by #495
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Milestone

Comments

@JonathanGregory
Copy link
Contributor

I've just read through the units_metadata text that was implemented today by PR #480 in the rendered versions, and noticed:

  • An omission which is so silly that it's funny, namely that I forgot to add the new units_metadata attribute to Appendix A. 😄 My proposed text is "Specifies the interpretation (on-scale, difference or unknown) of the unit of temperature appearing in the units attribute."
  • Some bolding which was included for clarity during the discussion and should have been removed.

I have prepared corrections for these in PR #495, and taken advantage of the opportunity to clarify the words in one place ("for guidance only regarding temperature: unknown, not as a CF convention") and to insert a missing comma.

Please could someone check and merge?

@JonathanGregory JonathanGregory added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Dec 4, 2023
@JonathanGregory JonathanGregory linked a pull request Dec 4, 2023 that will close this issue
4 tasks
@larsbarring
Copy link
Contributor

I have looked through the PR and agree with all suggestions. As we are many that have looked at the changes put forth in the first PR #480, we have our share in the burden (and perhaps dubious joy ;-) of the omission in Appendix A. Thanks @JonathanGregory for noting these. I will leave it at this for now to leave time and opportunity for yet another pair of eyes. Maybe @davidhassell could merge before minting 1.11.

@larsbarring larsbarring added this to the 1.11 milestone Dec 4, 2023
@davidhassell
Copy link
Contributor

Caught just in time - many thanks, Jonathan! It looks fine to me - merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants