Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support extra annotations on resoures in helm chart #175

Closed
thesuperzapper opened this issue Sep 7, 2023 · 5 comments · May be fixed by #214
Closed

support extra annotations on resoures in helm chart #175

thesuperzapper opened this issue Sep 7, 2023 · 5 comments · May be fixed by #214
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@thesuperzapper
Copy link

I would like to be able to set "global" annotations for all resources in the trust-manager helm chart.

The main purpose of this is to allow a single "combined" chart of cert-manager and trust-manager to be applied successfully using Argo CD. Right now, if a combined chart is created, the first sync will always fail (because trust-manager depends on cert-manager being ready).

However, if I could set annotations on all resources, I would be able to make use of Argo CD's Sync Waves to put all the trust-manager resources in a wave that happens after cert-manager.

For example, we might add a value called app.annotations to the chart (which adds no annotations by default), and use it like follows:

app:
  annotations:
    ## assuming cert-manager has a lower wave (or no wave) set
    argocd.argoproj.io/sync-wave: "5"
@thesuperzapper thesuperzapper mentioned this issue Oct 26, 2023
Open
@cert-manager-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@cert-manager-prow cert-manager-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024
@cert-manager-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
/remove-lifecycle stale

@cert-manager-prow cert-manager-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 6, 2024
@thesuperzapper
Copy link
Author

I think this issue is still important, and is causing me to run a forked version of the chart.

@cert-manager-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

@cert-manager-prow
Copy link
Contributor

@cert-manager-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add helm values for annotations thesuperzapper/trust-manager
2 participants
@thesuperzapper @cert-manager-bot