You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently timeouts for checking for success are scattered across tests (e.g. here) and so are hard to change.
They're also quite low and could easily flake in a resource constrained testing environment.
It would be better to have a single const controlling global timeouts to make this easier to change and to make it obvious what's happening.
The above linked code block could be rewritten to:
Eventually(func() bool {
Expect(f.Client().Get(f.Context(), client.ObjectKeyFromObject(&certificateRequest), &certificateRequest)).NotTo(HaveOccurred())
returnapiutil.CertificateRequestIsApproved(&certificateRequest)
}).WithTimeout(testTimeout).WithInterval(pollInterval).WithContext(ctx).Should(BeTrue(), "expected request to become approved in time")
Note that this also passes the context into the Eventually function which would be useful if we were to enforce a global timeout on all e2e tests in the future
The text was updated successfully, but these errors were encountered:
Currently timeouts for checking for success are scattered across tests (e.g. here) and so are hard to change.
They're also quite low and could easily flake in a resource constrained testing environment.
It would be better to have a single const controlling global timeouts to make this easier to change and to make it obvious what's happening.
The above linked code block could be rewritten to:
Note that this also passes the context into the
Eventually
function which would be useful if we were to enforce a global timeout on all e2e tests in the futureThe text was updated successfully, but these errors were encountered: