New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize the name used in the managed-by label of the webhook CA Secret to distinguish it from the CA Secret created by cert-manager #505

Open

wallrj opened this issue Sep 26, 2024 · 0 comments

Member

wallrj commented Sep 26, 2024 •

edited

Loading

In a followup PR we should parameterize the name, because this library is imported by approver-policy for its webhook CA certificate.

approver-policy/pkg/internal/cmd/cmd.go

Line 26 in e846d89

"github.com/cert-manager/cert-manager/pkg/server/tls/authority"

And at the same time, we should parameterize the CA common name, because that is also not correct for the approver-policy webhook CA.

Originally posted by @wallrj in cert-manager/cert-manager#7154 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment