Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration: GitLab vs GitHub Actions #8

Open
dolmen opened this issue May 5, 2022 · 4 comments · May be fixed by #17
Open

Continuous integration: GitLab vs GitHub Actions #8

dolmen opened this issue May 5, 2022 · 4 comments · May be fixed by #17

Comments

@dolmen
Copy link
Contributor

dolmen commented May 5, 2022

I found a .gitlab-ci.yml in the repository. Apparently It is running on gitlab.cern.ch to which external contributors like myself do not have access.

Would you be interested in a GitHub Actions CI jobs?

@reguero
Copy link
Contributor

reguero commented May 6, 2022

Dear @dolmen as you saw all our CI is currently running on the CERN Gitlab, on the other hand it would be interesting to see wheter similar CI can be done in GitHub.

@dolmen
Copy link
Contributor Author

dolmen commented May 7, 2022

I have work in progress for that, but the test suite fails because tests fails outside the CERN network.

#5 looks to be a major improvement to allow external contributors (Go Hack and beyond) to contribute.

@reguero When do you plan to review (and hopefully merge) #5 ?

I would like to contribute this work for the Go Hack, but my work depends on others work (and likewise, others contributors would benefit from my own PRs)...

@reguero
Copy link
Contributor

reguero commented May 10, 2022

As requested I have merged PR #5

As matter of fact, I have also merged PR #6 and #12

@reguero
Copy link
Contributor

reguero commented May 10, 2022

As for your #11 I think that @psaiz explained that after discussion, we realized that it would make very difficult to keep different levels in gitlab and github so we are not merging it for the moment.

@dolmen dolmen linked a pull request May 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants