Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop synchronizing interests #611

Closed
1 task
nathanielc opened this issue Nov 20, 2024 · 0 comments · Fixed by #632
Closed
1 task

Stop synchronizing interests #611

nathanielc opened this issue Nov 20, 2024 · 0 comments · Fixed by #632

Comments

@nathanielc
Copy link
Collaborator

Once #610 is complete we no longer need to synchronize interests transitively across the network.

DOD

  • Peers do not transitively synchronize interests across the network.
nathanielc added a commit that referenced this issue Dec 10, 2024
With this change the interests ring is no longer synchronized between
peers. A local node will still use the interest-svc to know its own
interests and the beginning of each Recon conversation negotiates shared
interests. Therefore it is no longer necessary to synchronize interests.

In the future we may decide that we want to use Recon to sync interests
instead of a linear sharing of interests before each conversation,
however that is only a performance optimization that is not important at
this stage.

Fixes #610
Fixes #611
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2024
* feat: stop synchronizing interests

With this change the interests ring is no longer synchronized between
peers. A local node will still use the interest-svc to know its own
interests and the beginning of each Recon conversation negotiates shared
interests. Therefore it is no longer necessary to synchronize interests.

In the future we may decide that we want to use Recon to sync interests
instead of a linear sharing of interests before each conversation,
however that is only a performance optimization that is not important at
this stage.

Fixes #610
Fixes #611

* fix: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant