Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release stackdriver stats and context changes #597

Closed
c24t opened this issue Apr 2, 2019 · 5 comments
Closed

Release stackdriver stats and context changes #597

c24t opened this issue Apr 2, 2019 · 5 comments
Assignees

Comments

@c24t
Copy link
Member

c24t commented Apr 2, 2019

We've got two large breaking unreleased changes on master: making the stackdriver stats exporter consume stats as metrics (#593) and adding a context API that replaces threadlocals with contextvars on recent python versions (#588).

We'll have to release versions 0.4.0 of the core library, 0.3.0 of opencensus-ext-stackdriver, and 0.1.0 of opencensus-context. We can continue to release ext packages from the same release branch as the main library (in this case the new v0.4.x branch), or start using separate release branches for each package.

cc @reyang

@c24t c24t added the GA-Effort label Apr 2, 2019
@c24t c24t self-assigned this Apr 2, 2019
@reyang
Copy link
Contributor

reyang commented Apr 2, 2019

Thanks for the heads up.

@reyang
Copy link
Contributor

reyang commented Apr 3, 2019

#599 introduced the contextvars backport for Py3.6, also added test cases.

@c24t
Copy link
Member Author

c24t commented Apr 5, 2019

Among other API changes #593 changed the return type of new_stats_exporter in the stackdriver exporter package.

This change may not be worth the trouble it causes since most users don't need access to the background thread that handles exporting (the method was changed to return this along with the exporter), and it forces everyone that uses the exporter to change their code. We may want to wait on changing the API until we make the same changes in the prometheus exporter, or until we have a better strategy for announcing API changes.

@reyang what do you think?

@reyang
Copy link
Contributor

reyang commented Apr 5, 2019

@c24t If we expect other breaking changes (e.g. the API change as you mentioned) in the next couple weeks, it makes sense to put the breaking changes together.

BTW, https://pypi.org/project/Deprecated/ seems to be promising.

@c24t
Copy link
Member Author

c24t commented Apr 9, 2019

Closed by #604.

@c24t c24t closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants