Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: asyncio support #234

Closed
tcolgate opened this issue Jul 13, 2018 · 1 comment
Closed

RFC: asyncio support #234

tcolgate opened this issue Jul 13, 2018 · 1 comment

Comments

@tcolgate
Copy link
Contributor

Modern python seems to be adopting asyncio. oc-python's execution_context is current based on thread local storage. This results in spans being misasigned when using tools such as sanic and aiohttp.
I've begun some work on support, and some feedback would be appreciated. We can move it back in tree if things get to a point where people find it acceptable.

Initial work was done here:
#232

I've moved these packages to:
https://github.com/QubitProducts/qubit-opencensus

I thought it made sense to raise an issue to track the work.

@c24t
Copy link
Member

c24t commented Apr 1, 2019

Sorry to have left this issue hanging @tcolgate. #588 adds support for using async contextvars instead of threading.local for context storage, and may solve this.

Feel free to reopen the issue if there's something that #588 doesn't solve.

@c24t c24t closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants