Include RequestsHash in header encoding/decoding #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d981efb.
A new field 'RequestsHash' was added to the header, and we needed to run go generate to regenerate the generated encoding/decoding and also update celo_block.go to account for the new field. Simplified the encoding and decoding in celo_block.go by simply casting the header into the right type for encoding/decoding. This ensures that we won't need to update celo_block.go in the future when fields are added or removed.
karlb
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates header encoding/decoding
A new field 'RequestsHash' was added to the header, and we needed to run
go generate to regenerate the generated encoding/decoding. We also
needed to update celo_block.go to account for the new field.
Simplified the encoding and decoding in celo_block.go by simply casting
the header into the right type for encoding/decoding. This ensures that
we won't need to update celo_block.go in the future when fields are
added or removed.
These changes allowed us to unskip the tests that were skipped during the celo11 rebase.
Fixes https://github.com/celo-org/celo-blockchain-planning/issues/854