Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipt handling for CIP-66 transaction #195

Open
Tracked by #64
ezdac opened this issue Jul 30, 2024 · 0 comments
Open
Tracked by #64

Receipt handling for CIP-66 transaction #195

ezdac opened this issue Jul 30, 2024 · 0 comments
Labels
type:enhancement New feature or request

Comments

@ezdac
Copy link

ezdac commented Jul 30, 2024

Implement the correct setting of receipt fields in the applyTransaction() function.
Think about how to handle the different gas-cost denominations (CIP-64 vs CIP-66) and how downstream consumers of the receipt deal with this (external RPC API, consensus.Engine.FinalizeAndAssemble(), etc).
Additionally, how was the Receipt.BaseFee (celo specific) and Receipt.EffectiveGasPrice used for Celo denominated CIP-64 transactions and how is this different from CIP-66 transactions. Are additional fields needed and what are the consequences of changing this public API.

@ezdac ezdac changed the title Receipt handling Receipt handling for CIP-66 transactions Jul 30, 2024
@ezdac ezdac changed the title Receipt handling for CIP-66 transactions Receipt handling for CIP-66 transaction Jul 30, 2024
@ezdac ezdac added the type:enhancement New feature or request label Jul 30, 2024
@ezdac ezdac added this to the 4 - Celo Alfajores migration milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants