Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for legacy transaction signing #168

Open
piersy opened this issue Jul 8, 2024 · 0 comments
Open

Add tests for legacy transaction signing #168

piersy opened this issue Jul 8, 2024 · 0 comments
Labels
type:bug Something isn't working type:tests

Comments

@piersy
Copy link

piersy commented Jul 8, 2024

This PR - #165 added support for singing legacy transactions but did not provide any tests of the functionality. The functionality should be covered to a good degree by the test that compares rpc outputs between celo and cel2 implementations (because it will verify that the from field is correctly generated for all transactions occurring before the transition to cel2). However it would be good to have some unit tests of this functionality to prevent regressions.

This ticket covers adding those tests. We could import celo-blockchain and compare it's output with the new signing implementation, or we could take historical transactions and ensure that the signer produces correct result, this would be for all the transaction types.

Additionally some lower level tests would be useful, such as a test ensuring the ordering of forks is correct. For example checking that transactions deprecated in the cel2 fork are not signed when the cel2 fork is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:tests
Projects
None yet
Development

No branches or pull requests

2 participants