Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for GetBlockReceipt api method #156

Open
piersy opened this issue Jun 25, 2024 · 1 comment
Open

Add a test for GetBlockReceipt api method #156

piersy opened this issue Jun 25, 2024 · 1 comment
Labels
type:bug Something isn't working type:tests

Comments

@piersy
Copy link

piersy commented Jun 25, 2024

We don't have a test for this, and it's going to be tricky to make one because that method exists to serve block receipts that are an artefact of the old celo-blockchain codebase. As such we don't have any code in this codebase that produces block receipts.

So maybe the best approach would be to use a small datadir generated from legacy celo, however that would probably still be a few MBs which is still kind of too large to be reasonable.

@piersy piersy added the type:bug Something isn't working label Jun 25, 2024
@palango
Copy link

palango commented Jun 25, 2024

Can't we just serialize one block that has a block receipt and load that for the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:tests
Projects
None yet
Development

No branches or pull requests

3 participants