-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update codecov.ymal with modern options #441
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking until we can figure out why it is not giving us any feedback
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 68.15% 68.22% +0.07%
==========================================
Files 292 292
Lines 11347 11347
Branches 1678 1652 -26
==========================================
+ Hits 7733 7742 +9
+ Misses 3514 3470 -44
- Partials 100 135 +35
|
looking at the coverage it seems to not be seeing that Command.run for cli. wheras before it did. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useful coverage!
Description
Various coverage improvements
PR-Codex overview
This PR updates the
codecov
dependency version, modifies thecodecov.yml
configuration, and adds tests for theBalance
command in thepackages/cli/src/commands/account/balance.test.ts
file.Detailed summary
codecov
version from3.6.5
to3.8.3
inpackage.json
andyarn.lock
.codecov.yml
configuration settings, including:threshold
to0%
and setbase
toauto
.only_pulls
option and modifiedcomment
layout.Balance
command, covering: