Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codecov.ymal with modern options #441

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Nov 15, 2024

Description

Various coverage improvements


PR-Codex overview

This PR updates the codecov dependency version, modifies the codecov.yml configuration, and adds tests for the Balance command in the packages/cli/src/commands/account/balance.test.ts file.

Detailed summary

  • Updated codecov version from 3.6.5 to 3.8.3 in package.json and yarn.lock.
  • Changed codecov.yml configuration settings, including:
    • Updated threshold to 0% and set base to auto.
    • Added only_pulls option and modified comment layout.
    • Introduced component management rules for various components.
  • Added tests for the Balance command, covering:
    • Displaying account balances in multiple currencies.
    • Displaying account balances in a specified currency after topping up.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner November 15, 2024 09:20
Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 4b9d5af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@aaronmgdr aaronmgdr self-requested a review November 15, 2024 10:01
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking until we can figure out why it is not giving us any feedback

@nicolasbrugneaux nicolasbrugneaux linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (42d091f) to head (4b9d5af).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   68.15%   68.22%   +0.07%     
==========================================
  Files         292      292              
  Lines       11347    11347              
  Branches     1678     1652      -26     
==========================================
+ Hits         7733     7742       +9     
+ Misses       3514     3470      -44     
- Partials      100      135      +35     
Components Coverage Δ
celocli 69.82% <ø> (+0.18%) ⬆️
dev-utils ∅ <ø> (∅)
sdk ∅ <ø> (∅)
wallets ∅ <ø> (∅)
viem-sdks ∅ <ø> (∅)
---- 🚨 Try these New Features:

@aaronmgdr
Copy link
Member

looking at the coverage it seems to not be seeing that Command.run for cli. wheras before it did.

@nicolasbrugneaux nicolasbrugneaux enabled auto-merge (squash) November 18, 2024 15:51
@nicolasbrugneaux nicolasbrugneaux self-assigned this Nov 18, 2024
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful coverage!

@nicolasbrugneaux nicolasbrugneaux merged commit 41c561b into master Nov 18, 2024
29 of 42 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the chore/coverage-improvements branch November 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code coverage improvements
2 participants