Mento V1 to V2 upgrade (exchange command)

[philbow61]

Hello everyone,

The Mento team will propose a new mento upgrade in the next few weeks that will complete the transition towards Mento V2, fully deprecating the old V1 Exchanges as well as Granda Mento, which will be replaced by the Broker contract in Multi Collateral Mento. This upgrade will affect the celocli exchange and celocli grandamento command as those contracts will no longer work. We suggest completely removing the grandamento command and integrating Mento V2 on the old exchange command for the different stables.

The easiest way to integrate Mento V2 is by using the mento-sdk. Examples on how to use the sdk can be found in the mento-sdk-examples repo.

For any question regarding the upgrade or the integration of Mento V2, don’t hesitate to reach out to us via Discord.

[arthurgousset]

Thanks re-posting your message here @philbow61, appreciate it!

I propose that the Mento team makes PRs to ensure that the celocli exchange and celocli grandamento commands continue to work as desired during the deprecation process.

I don't foresee that we (@celo-org/devtooling) will become subject-matter experts in the new Mento protocol and smart contracts.

We'll happily provide PR reviews similar to the feedback we provided here:

• fix: celocli network:contracts command post Mento upgrade 04  celo-monorepo#10792

Could you remind me when you expect to make these changes and when they have to be released by? In other words, what's your timeline for the deprecation process?

Thanks!

[aaronmgdr]

Removing grandamento makes sense, it really turned out not to be viable.

[arthurgousset]

Hey @philbow61, pinging on my proposal above. The exchange command is effectively broken since the Mento v1 deprecation.

• cUSD exchange doesn't work  #75

Are you able to prioritise upgrading the exchange command in @celo/celocli with the new Mento v2 smart contracts?

[arthurgousset]

Contacted Mento in Discord DM today:

I'm looking to prioritise support for Mento v2 in @celo/celocli.

TLDR:

• The exchange command is broken in the celo CLI since Mento v1 deprecation
• This means that users cannot exchange CELO for cStables using the Celo CLI at the moment
• I would appreciate it if a Mento engineer could submit a PR that makes the exchange CLI command work with Mento v2
• We (@celo-org/devtooling) are open to supporting you with PR reviews and feedback, but don't foresee becoming subject-matter experts on Mento v2, so we'd really appreciate a hand here.

[aaronmgdr]

can we just remove this feature?

[arthurgousset]

Ideally, yes we (@celo-org/devtooling) don't commit to maintaining CLI commands for smart contracts we don't actively maintain (e.g. Mento smart contracts, since that's now with Mento Labs).

But, from a developer experience perspective, we want to make that transition as smooth as possible.

[bayological]

Hi @arthurgousset , we will not be integrating MentoV2 into the Celo CLI. Instead, I'd advise you mark the exchange command as 'deprecated'. For those interested in learning how to use Mento V2 for triggering exchanges, please point them to the Mento SDK examples repo(https://github.com/mento-protocol/mento-sdk-examples). In future, we will be developing a dedicated Mento CLI. This will include specific commands that allows users to initiate exchanges through the broker.

[arthurgousset]

Thanks for the context @bayological 👍

we will be developing a dedicated Mento CLI. This will include specific commands that allows users to initiate exchanges through the broker.

Do you have an approximate date for the first release of the Mento CLI? How high is this on your list of priorities?

A second, more exploratory question, would consider making a Mento plugin for the Celo CLI?
If you'd be open to explore that option, you could benefit from some basic utilities we implement at the Celo CLI level and only add the Mento-specific commands on top of it.

We are considering refactoring the frameworks we use in the CLI, so these are decision you could influence and win time on.

Let me know what you think :)

[arthurgousset]

(for future reference) Here is an example use case that is currently blocked (submitted by @martinvol):

• cUSD exchange doesn't work  #75

Use case:

• account is in a Celo full node
• account needs cUSD, but only has CELO
• account can't swap on app.mento.org, because it's in a full node.

Is this a use case that is on your radar at Mento? (cc @bayological @philbow61)

[jeanregisser]

Hey,

We were just bitten by this too on our CI, we have a script which exchanges tokens on Alfajores using the original Exchange contract (mento v1).

Error: Exchange not (yet) registered
    at new UnregisteredError (/home/runner/work/wallet/wallet/node_modules/@celo/contractkit/lib/address-registry.js:68:23)

We’re using an old ContractKit though (v3.2).

So this means governance updated the registry to remove the Exchange contract, right?

[arthurgousset]

this means governance updated the registry to remove the Exchange contract, right?

That's correct, the following core contracts were deprecated:

Last updated	Name	Contract
2023-12-19 14:50	�Exchange	0x
2023-12-19 14:50	ExchangeEUR	0x
2023-12-19 14:50	ExchangeBRL	0x
2023-12-19 14:50	GrandaMento	0x

Source: dune.com/arthurgousset/corecontracts

I recommend you replace the current swapping logic with @mento-protocol/mento-sdk.

For example, we've done that for the testnet faucet (faucet.celo.org), which sometimes swaps CELO into cUSD/cEUR/cREAL, when a user requests cStable testnet tokens:

• switch from exchange to broker contract for swaps faucet#42

[jeanregisser]

Thanks very helpful. 👍

On a side note, what's the best way to see governance changes on Alfajores? Or a place to stay on top of these changes?
For Celo mainnet I mostly use https://celo.stake.id/

[arthurgousset]

Good question 🤔 I think celo.stake.id seems like a good place to check. My hunch is alfajores and mainnet governance proposals move in lock step (so they should be "equal"), but I'm not 100% sure.

In the case of the Mento V1 deprecation, we noticed this was happening via forum.celo.org in Mento Upgrade #1 deployment timeline.

[aaronmgdr]

they are not equal. there have been more proposals on alfajores

[arthurgousset]

Good to know, thanks for sharing 👍

[arthurgousset]

Brief update (as of Tue, Jan 30)

• We (@celo-org/devtooling) are working on a release for @celo/celocli that will patch the exchange command. That means, all users of the Celo CLI will be able to continue using the exchange command.
  • Exchange tokens via mento broker #106
• Separately, the Mento team will be releasing a Mento CLI (v1) with support for a similar exchange command.
• The short/medium-term plan is to support the existing exchange command to avoid hard breaks in the developer experience, and give developers a longer and smoother migration experience.
• The long-term plan is not decided, but one option we are considering is to deprecate the Celo CLI exchange command in favour of the Mento CLI exchange command. This is not decided yet, and we will give ample time to chime in, as well as migrate if necessary.

[arthurgousset]

Update (as of Wed, Feb 7)

We just released a beta version of the CLI (4.0.0-beta.1) that fixes the exchange command.

Could you test it and let us know if anything doesn't work as you would expect? (cc @martinvol @philbow61)
Thanks!

[aaronmgdr]

@celo/celocli@latest supports exchange through broker as of version 4.0.0

• Version Packages #137

[arthurgousset]

Update (as of Wed, Feb 14)

We just released @celo/[email protected] (changelog) that fixes the exchange command.