Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise currency pair in metric labels #4

Open
bowd opened this issue Mar 17, 2021 · 2 comments
Open

Standardise currency pair in metric labels #4

bowd opened this issue Mar 17, 2021 · 2 comments

Comments

@bowd
Copy link
Collaborator

bowd commented Mar 17, 2021

Expected Behavior

Prometheus metrics that are segmented by currencyPair should have a consistent label. Specifically:

currencyPair: "CELOUSD" | "CELOEUR" | "CELOBTC"

Current Behavior

We have two ways of labelling metrics:

pair: "CELO/USD" | "CELO/EUR" | "CELO/BTC"
currencyPair: "CELOUSD" | "CELOEUR" | "CELOBTC"

Having this duplications makes it harder to leverage dashboard-wide filters in a smart way.

Reason for need: Consistent dashboards for stablecoins are a bit difficult to create at this time. Reporting is harder to scale.

@tkporter
Copy link
Contributor

Does this include redeployment or changing any metrics/dashboards?

@bowd
Copy link
Collaborator Author

bowd commented Mar 23, 2021

I think the metrics/dashboards should be included but I'm starting to think we need a new way of dealing with deployments, cose I also have this questions for every task. Maybe it's time to come up with a deployment schedule for oracles. This is outside the scope of this conversation but we could setup a schedule where we upgrade Alfajores -> Baklava -> Mainnet consistently with a certain cadence so we can separate the deployment question from features :-/

But yeah for this I'd say we should take into account both deployment and updating the dashboards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants