Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected behaviour of RowRoots() and ColRoots() on an incomplete EDS is undefined #122

Closed
musalbas opened this issue Sep 15, 2022 · 5 comments · Fixed by #213
Closed

Expected behaviour of RowRoots() and ColRoots() on an incomplete EDS is undefined #122

musalbas opened this issue Sep 15, 2022 · 5 comments · Fixed by #213
Assignees
@rootulp
Labels
good first issue Good for newcomers

Comments

@musalbas
Copy link
Member

No description provided.

@adlerjohn adlerjohn added the good first issue Good for newcomers label Sep 30, 2022
@rootulp
Copy link
Collaborator

rootulp commented Jul 4, 2023

I assume "incomplete" in this context is an EDS with one or more shares missing (i.e. set to nil). If that's the case, I would expect RowRoots() and ColRoots() to return an error if called on an incomplete EDS. #208 includes an API breaking change to RowRoots() and ColRoots() so they return an error parameter so this issue appears unblocked.

@rootulp rootulp self-assigned this Jul 4, 2023
@musalbas
Copy link
Member Author

musalbas commented Jul 4, 2023

What is the current behavior now?

@rootulp
Copy link
Collaborator

rootulp commented Jul 4, 2023 •
edited
Loading

Currently RowRoots returns row roots for an incomplete EDS. It pushes nil shares to the tree and generates Merkle roots. See 1977625

@musalbas
Copy link
Member Author

musalbas commented Jul 4, 2023

Wondering if there's any reason where it would make sense to return row roots for an incomplete EDS, but I can't think of any.

@rootulp rootulp mentioned this issue Jul 4, 2023
Merged
@staheri14
Copy link
Contributor

I think this might be relevant #214

@rootulp rootulp mentioned this issue Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: return an error for RowRoots and ColRoots if EDS incomplete rootulp/rsmt2d
4 participants
@adlerjohn @rootulp @musalbas @staheri14