Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Versioned timeouts CIP draft #216

Merged
merged 28 commits into from
Oct 17, 2024
Merged

feat: Versioned timeouts CIP draft #216

merged 28 commits into from
Oct 17, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Oct 10, 2024

Overview

rootulp
rootulp reviewed Oct 10, 2024
View reviewed changes
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
@jcstein jcstein mentioned this pull request Oct 10, 2024
Merged
@jcstein jcstein self-assigned this Oct 10, 2024
This was referenced Oct 11, 2024
Open
Closed
@jcstein jcstein requested a review from rootulp October 16, 2024 01:05
jcstein
jcstein commented Oct 16, 2024
View reviewed changes
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 16, 2024
View reviewed changes
cips/SUMMARY.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 16, 2024
View reviewed changes
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 16, 2024
View reviewed changes
cips/README.md Outdated Show resolved Hide resolved
rootulp
rootulp reviewed Oct 16, 2024
View reviewed changes
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated Show resolved Hide resolved
cips/cip-6-second-blocks.md Outdated

The motivation for this CIP stems from a discussion in Core Devs Call 17, where it was proposed to reduce the block time to 6 seconds from 12 seconds.

## Specification
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this specification section should include a short blurb on why TimeoutCommit and TimeoutPropose were moved from local config parameters into versioned parameters controlled by the state machine. cc: @staheri14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using this for now "The TimeoutCommit and TimeoutPropose parameters were moved from local config parameters into versioned parameters controlled by the state machine to ensure consistency and correctness across different protocol versions. This change allows the system to adapt dynamically to version-specific requirements, improving overall stability and interoperability during upgrades."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

837357a

@jcstein jcstein requested a review from rootulp October 16, 2024 14:58
jcstein
jcstein commented Oct 16, 2024
View reviewed changes
cips/cip-26.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 16, 2024
View reviewed changes
cips/cip-26.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 16, 2024
View reviewed changes
cips/cip-26.md Outdated Show resolved Hide resolved
staheri14
staheri14 reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes as requested @jcstein

cips/README.md Outdated Show resolved Hide resolved
cips/cip-26.md Outdated Show resolved Hide resolved
@jcstein
Copy link
Member Author

jcstein commented Oct 17, 2024

thank you @staheri14!

jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/README.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/cip-25.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/README.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/cip-26.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/cip-26.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/README.md Outdated Show resolved Hide resolved
@jcstein jcstein changed the title feat: add 6 second block CIP draft feat: Versioned timeouts CIP draft Oct 17, 2024
staheri14
staheri14 reviewed Oct 17, 2024
View reviewed changes
cips/cip-26.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/cip-26.md Outdated Show resolved Hide resolved
jcstein
jcstein commented Oct 17, 2024
View reviewed changes
cips/cip-25.md Outdated Show resolved Hide resolved
@jcstein jcstein merged commit edd2e09 into main Oct 17, 2024
2 checks passed
@jcstein jcstein deleted the jcs/cip-6-seconds branch October 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staheri14 staheri14 staheri14 left review comments

@rootulp rootulp rootulp approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@jcstein jcstein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcstein @rootulp @staheri14