Add a calculator to integrate range from energy loss #1544
+259
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we refactor the physics table construction we'll probably move toward replacing the
Process::step_limits
withmacro_xs
andenergy_loss
(initially the process-integrated energy loss, but eventually letting each process provide its own and summing them) and then integrating the range from the energy loss ourselves. This adds a calculator for integrating the range from a dedx grid and uses it in the physics grid construction.I'm leaving this as a draft for now because it changes a lot of test results. I think this could be because of differences in the spline interpolation, but it would be good to understand and discuss what we want to do before I go too far with it. I added a failing test comparing range values calculated from the imported dedx to the imported range to get a rough idea of the magnitude of the differences.