Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a calculator to integrate range from energy loss #1544

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

amandalund
Copy link
Contributor

As we refactor the physics table construction we'll probably move toward replacing the Process::step_limits with macro_xs and energy_loss (initially the process-integrated energy loss, but eventually letting each process provide its own and summing them) and then integrating the range from the energy loss ourselves. This adds a calculator for integrating the range from a dedx grid and uses it in the physics grid construction.

I'm leaving this as a draft for now because it changes a lot of test results. I think this could be because of differences in the spline interpolation, but it would be good to understand and discuss what we want to do before I go too far with it. I added a failing test comparing range values calculated from the imported dedx to the imported range to get a rough idea of the magnitude of the differences.

@amandalund amandalund added enhancement New feature or request physics Particles, processes, and stepping algorithms labels Dec 10, 2024
@amandalund amandalund requested a review from sethrj December 10, 2024 05:38
Copy link

Test summary

  424 files    665 suites   26s ⏱️
1 332 tests 1 278 ✅ 39 💤 15 ❌
2 428 runs  2 394 ✅  8 💤 26 ❌

For more details on these failures, see this check.

Results for commit 9d389b1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant