Add option to use spline-interpolated energy loss #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ysicsParamsOptions
…ut in the simple-driver.py
Test summary 3 861 files 5 970 suites 4m 9s ⏱️ Results for commit 0f7594d. ♻️ This comment has been updated with latest results. |
sethrj
added
enhancement
added 3 commits
November 20, 2024 16:03
… grid created being too small
…pline template. Failing due to energy grid of size 2 in test
…s in MockProcess. Also alter scattering mock process to have 3 xs points instead of 2
sethrj
reviewed
Dec 2, 2024
|
Great work @lebuller ! There are just a few things to look at. |
added 6 commits
December 3, 2024 10:35
…cks on that can be removed
sethrj
changed the title
pcanal
pushed a commit
to pcanal/celeritas
that referenced
this pull request
Dec 3, 2024
…1496) * Adds `spline_eloss_order` variable to the PhysicsParamsScalars and PhysicsParamsOptions * Adds option for xs calculation from spline in energy loss calculation * Adds spline order to the runner input setup and includes it as an input in the simple-driver.py * Set a default of 1st order interpolation in the input file * Adds spline physics step test. Currently fails due to the energy loss grid created being too small * Adds spline_calc_xs function for testing the make_calculator with a spline template. Failing due to energy grid of size 2 in test * Alter the vector length to store a range of values for the energy loss in MockProcess. Also alter scattering mock process to have 3 xs points instead of 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an input option in the runner,
spline_eloss_order, which is passed toPhysicsParams::Inputas an option. This option is used to define the order of interpolation to be preformed incalc_mean_energy_lossinPhysicsStepUtils.hh. If this order is 1 the existing linear cross-section calculator is used and if it is greater than 1 a spline calculator of the given order is used.