Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdml-to-dot and improve celer-geo #1252

Merged
merged 7 commits into from
May 28, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented May 24, 2024

This adds the small ability to use null values as input defaults for geometry/namespace (see celeritas-project/celerpy#3) and also adds a script to export a Geant4 logical volume hierarchy from a GDML to a GraphViz representation (useful for understanding the depth and complexity of a realistic problem such as hgcal). We might want to move that one to celer-viz since it's pure python.

@sethrj sethrj added minor Minor internal changes or fixes app Application front ends labels May 24, 2024
@sethrj sethrj requested a review from amandalund May 24, 2024 05:43
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good, just some build errors from the missing #include "celeritas_test.hh".

@sethrj
Copy link
Member Author

sethrj commented May 24, 2024

Oops that's a rebase error

@sethrj sethrj enabled auto-merge (squash) May 27, 2024 13:36
@sethrj sethrj merged commit c864497 into celeritas-project:develop May 28, 2024
27 of 28 checks passed
@sethrj sethrj deleted the visualize-scripts branch May 31, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Application front ends minor Minor internal changes or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants