Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not plot Peak_Tim metrics boxplots #50

Open
kristaniguchi opened this issue Mar 4, 2020 · 4 comments
Open

Do not plot Peak_Tim metrics boxplots #50

kristaniguchi opened this issue Mar 4, 2020 · 4 comments
Assignees

Comments

@kristaniguchi
Copy link

Peak timing metrics are no longer included as functional flow metrics. Do not create boxplots for them.

@nickrsan
Copy link
Member

nickrsan commented Mar 4, 2020

Just acknowledging this one - I'll drop those metrics.

@kristaniguchi
Copy link
Author

Thanks!

@nickrsan
Copy link
Member

Hey @alyssaobester and @ryanpeek before I drop these metrics, can you confirm that you don't have a use case for them where I should make it an option to include or not include them in plotting?

Also, should they be dropped completely (ie, not in the data frames either) and not just from plotting?

@nickrsan nickrsan self-assigned this Mar 13, 2020
@ryanpeek
Copy link
Contributor

This is fine by me. I don't think they would be needed in the dataframe either, but fairly easy to remove after downloading as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants