pkg: Add check for php-json #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php-json package is used by webgui. While
the build would pass if php-json package is
missing. It may not render the graphs at all.
This patch adds check for php-json. During the
time of configure. It does not change workflow
or alters functions. If php-json is missing it
will throw an "warning" under config.log so
user can review it post running and add that if
necessary. Hard requirement of php-json was not
selected as not all users would like to use
webgui. Therefore the changes under robinhood.spec.in
("BuildRequires:") was not chosen.
Change-Id: I45c3aeccdd4983a5ae9935dc383b55ced9ffbc5e
Signed-off-by: Arshad Hussain <[email protected]>
|
Isn't this something to be added in the %Requires section of the robinhood-webgui package? I don't get why requiring this package at build time would affect the rendering on the system where the generated RPM is finally installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-json package is used by webgui. While
the build would pass if php-json package is
missing. It may not render the graphs at all.
This patch adds check for php-json. During the
time of configure. It does not change workflow
or alters functions. If php-json is missing it
will throw an "warning" under config.log so
user can review it post running and add that if
necessary. Hard requirement of php-json was not
selected as not all users would like to use
webgui. Therefore the changes under robinhood.spec.in ("BuildRequires:") was not chosen.
Change-Id: I45c3aeccdd4983a5ae9935dc383b55ced9ffbc5e