Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsii-rosetta peer dependency outdated #1643

Open
aripalo opened this issue Nov 19, 2024 · 3 comments
Open

jsii-rosetta peer dependency outdated #1643

aripalo opened this issue Nov 19, 2024 · 3 comments
Labels

Comments

@aripalo
Copy link
Contributor

aripalo commented Nov 19, 2024

jsii-rosetta peer dependency defined in jsii-docgen package.json "maxes out" at version 5.5.0, but there is now a fresh version 5.6.0 available.

This blocks upgrading JSII in Projen projects to 5.6.0.

An example output when trying to install dependencies n Projen+JSII powered project:

❯ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: XXXXXXXXXX
npm ERR! Found: [email protected]
npm ERR! node_modules/jsii-rosetta
npm ERR!   dev jsii-rosetta@"~5.6.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer jsii-rosetta@"^1.85.0 || ~5.0.14 || ~5.1.2 || ~5.2.0 || ~5.3.0 || ~5.4.0 || ~5.5.0" from [email protected]
npm ERR! node_modules/jsii-docgen
npm ERR!   dev jsii-docgen@"^10.5.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/Ari.Palo/.npm/_logs/2024-11-19T17_39_56_792Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/Ari.Palo/.npm/_logs/2024-11-19T17_39_56_792Z-debug-0.log
@aripalo
Copy link
Contributor Author

aripalo commented Nov 19, 2024

I started working on a fix. Unless any issues, I'm gonne send a PR.

@aripalo
Copy link
Contributor Author

aripalo commented Nov 19, 2024

There is a blocking issue for my PR contribution to this:

aripalo added a commit to aripalo/jsii-docgen that referenced this issue Nov 19, 2024
aripalo added a commit to alma-cdk/project that referenced this issue Nov 19, 2024
This reverts commit a593713.

JSII 5.6.0 was released just several hours ago and therefore the jsii ecosystem as a whole is not yet ready for it. See for example: cdklabs/jsii-docgen#1643
@iliapolo iliapolo added the p1 label Nov 25, 2024
@iliapolo
Copy link
Contributor

Thanks @aripalo for reporting this. Looks like we missed a step in the release of rosetta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants