From 21730f87df55029f37742a63914b5e74e4b43407 Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Tue, 19 Dec 2023 13:09:25 +0000 Subject: [PATCH] node18 but don't enforce it --- .github/workflows/build.yml | 4 ++-- .github/workflows/release.yml | 6 +++--- .github/workflows/upgrade-dev-deps-main.yml | 2 +- .github/workflows/upgrade-main.yml | 2 +- .projen/deps.json | 2 +- .projenrc.ts | 5 +++-- package.json | 5 +---- yarn.lock | 10 ++++++---- 8 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4d6a23e2..cf79c40c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -23,7 +23,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: 18.x - name: Install dependencies run: yarn install --check-files - name: build @@ -91,7 +91,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: 18.x - name: Install dependencies run: yarn install --check-files - name: Install Rosetta version diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e7af6a5c..0a2f7ba1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -28,7 +28,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: 18.x - name: Install dependencies run: yarn install --check-files --frozen-lockfile - name: release @@ -56,7 +56,7 @@ jobs: steps: - uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: 18.x - name: Download build artifacts uses: actions/download-artifact@v3 with: @@ -81,7 +81,7 @@ jobs: steps: - uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: 18.x - name: Download build artifacts uses: actions/download-artifact@v3 with: diff --git a/.github/workflows/upgrade-dev-deps-main.yml b/.github/workflows/upgrade-dev-deps-main.yml index f86173fe..2eec2005 100644 --- a/.github/workflows/upgrade-dev-deps-main.yml +++ b/.github/workflows/upgrade-dev-deps-main.yml @@ -21,7 +21,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: 18.x - name: Install dependencies run: yarn install --check-files --frozen-lockfile - name: Upgrade dependencies diff --git a/.github/workflows/upgrade-main.yml b/.github/workflows/upgrade-main.yml index 0a177a1f..48f9d830 100644 --- a/.github/workflows/upgrade-main.yml +++ b/.github/workflows/upgrade-main.yml @@ -21,7 +21,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: 18.x - name: Install dependencies run: yarn install --check-files --frozen-lockfile - name: Upgrade dependencies diff --git a/.projen/deps.json b/.projen/deps.json index d5ec7e88..b44b6f4b 100644 --- a/.projen/deps.json +++ b/.projen/deps.json @@ -10,7 +10,7 @@ }, { "name": "@types/node", - "version": "^16", + "version": "^18", "type": "build" }, { diff --git a/.projenrc.ts b/.projenrc.ts index 1701150c..52710b3a 100644 --- a/.projenrc.ts +++ b/.projenrc.ts @@ -41,8 +41,9 @@ const project = new CdklabsTypeScriptProject({ }, autoApproveUpgrades: true, - minNodeVersion: '16.0.0', - workflowNodeVersion: '16.x', + minNodeVersion: '18.12.0', + setNodeEngineVersion: false, + workflowNodeVersion: '18.x', jestOptions: { jestConfig: { setupFilesAfterEnv: ['/test/setup-jest.ts'], diff --git a/package.json b/package.json index a518b780..1309fa3d 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "devDependencies": { "@types/fs-extra": "^9.0.13", "@types/jest": "^29", - "@types/node": "^16", + "@types/node": "^18", "@types/semver": "^7.5.6", "@typescript-eslint/eslint-plugin": "^6", "@typescript-eslint/parser": "^6", @@ -70,9 +70,6 @@ "semver": "^7.5.4", "yargs": "^16.2.0" }, - "engines": { - "node": ">= 16.0.0" - }, "main": "lib/index.js", "license": "Apache-2.0", "version": "0.0.0", diff --git a/yarn.lock b/yarn.lock index 3d4d585d..ca2815c3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -846,10 +846,12 @@ dependencies: undici-types "~5.26.4" -"@types/node@^16": - version "16.18.68" - resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.68.tgz#3155f64a961b3d8d10246c80657f9a7292e3421a" - integrity sha512-sG3hPIQwJLoewrN7cr0dwEy+yF5nD4D/4FxtQpFciRD/xwUzgD+G05uxZHv5mhfXo4F9Jkp13jjn0CC2q325sg== +"@types/node@^18": + version "18.19.3" + resolved "https://registry.yarnpkg.com/@types/node/-/node-18.19.3.tgz#e4723c4cb385641d61b983f6fe0b716abd5f8fc0" + integrity sha512-k5fggr14DwAytoA/t8rPrIz++lXK7/DqckthCmoZOKNsEbJkId4Z//BqgApXBUGrGddrigYa1oqheo/7YmW4rg== + dependencies: + undici-types "~5.26.4" "@types/normalize-package-data@^2.4.0": version "2.4.4"