Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live deployment of PR's #486

Open
iliapolo opened this issue Oct 10, 2021 · 2 comments
Open

Live deployment of PR's #486

iliapolo opened this issue Oct 10, 2021 · 2 comments
Labels
effort/medium About 3 days priority/p3 We will be very happy to implement it but nothing will happen if we don't risk/medium Time estimation may be doubled tooling Updates or additions to developer tooling

Comments

@iliapolo
Copy link
Contributor

Changes to the webapp usually result in some visual changes that we want to inspect and provide feedback on.

Right now, we do this by capturing snapshots on the changes from our local development environments. Apart from being a bit risky (maybe the snapshot was taken from some stale code..?), it also doesn't allow reviewers to properly evaluate the changes.

We could leverage GitHub Deployment and deploy a live environment for every PR, this deployment will post a URL in the status check that can be navigated to and inspected.

To reduce costs or un-necessary deployments, we could make it so deployments only happen for PR's labeled with some label, added by the author.
@iliapolo iliapolo added priority/p3 We will be very happy to implement it but nothing will happen if we don't effort/medium About 3 days risk/medium Time estimation may be doubled labels Oct 10, 2021
@github-actions
Copy link
Contributor

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Dec 10, 2021
@iliapolo
Copy link
Contributor Author

Keep

@Chriscbr Chriscbr removed the stale label Dec 17, 2021
@gabewomble gabewomble added the tooling Updates or additions to developer tooling label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/medium About 3 days priority/p3 We will be very happy to implement it but nothing will happen if we don't risk/medium Time estimation may be doubled tooling Updates or additions to developer tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iliapolo @Chriscbr @gabewomble