Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add support for credentials to be passed to the source and destination #8

Open
scanlonp opened this issue Aug 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@scanlonp
Copy link
Contributor

The credentials would be used for the docker login so that external registries could be accessed by CodeBuild.

@athewsey
Copy link

Think I just came across this (unless I'm missing some other way to solve it?)

I was hoping to build and deploy a Dockerfile that starts:

ARG BASE_IMAGE
FROM ${BASE_IMAGE}

...Where BASE_IMAGE is a SageMaker DLC image URI: So is hosted elsewhere in an AWS-managed ECR account that needs a docker login.

For what it's worth, since a Dockerfile may have multiple FROM statements, I guess it might be necessary to support multiple source credentials?

@scanlonp
Copy link
Contributor Author

@athewsey I may be misunderstanding what you are trying to do, but I am not sure this construct can help you build and run the image in this way. Since this construct moves around pre-existing images in ECR, is the image your Dockerfile defines already in ECR?

If it is, and you are getting errors using this construct, would you be able to provide the code you are attempting to deploy and the results of the CodeBuild job? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants