Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some exotic v1 stacks aren't identified when aws-cdk is listed by itself in the Modules property #610

Open
brandondahler opened this issue Jan 10, 2024 · 1 comment

Comments

@brandondahler
Copy link

Stacks we have deployed contain a very limited set of information in the CDKMetadata modules section but are notably v1.

The complete CDKMetadata resource in our stack is:

  CDKMetadata:
    Type: AWS::CDK::Metadata
    Properties:
      Modules: aws-cdk=1.119.0

This appears to not be matching because the code assumes that @aws-cdk/core will be included in the list of modules on this line

@brandondahler
Copy link
Author

I speculate that this might happen when the @aws-cdk/core or monocdk version is less than 1.93, but the aws-cdk cli package used is newer; however, I haven't looked closely to see if this is the case.

@brandondahler brandondahler changed the title Some exotic v1 stacks aren't identified if @aws-cdk/core module isn't listed in modules Some exotic v1 stacks aren't identified when aws-cdk is listed by itself in Modules property Jan 10, 2024
@brandondahler brandondahler changed the title Some exotic v1 stacks aren't identified when aws-cdk is listed by itself in Modules property Some exotic v1 stacks aren't identified when aws-cdk is listed by itself in the Modules property Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant