-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs to Note #3
Comments
Yes old but useful as you say. PR are welcome. I will be happy to merge. |
@MediaMeasure any chance you could submit a PR or demonstrate a fix for number 1? |
kpfa
added a commit
to kpfa/icecast-logs-parser
that referenced
this issue
Jan 8, 2021
fixes issue no. 2 of Bugs to Note cdgraff#3
cdgraff
added a commit
that referenced
this issue
Jan 8, 2021
clear values_to_insert Bugs to Note #3
thanks @kpfa merged your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I know it must have been many years since you must have thought out this.
I have found your code helpful in allowing me to setup icecast log parsing.
For future stumblers there is two major bugs that needs to be corrected/addressed:
If a log file has 199 lines, this code will only capture the first full 100 entries as the insert is only done under the "if hits_counter == HIST_PER_QUERY" section.
The "values_to_insert" array needs to be cleared after an insert. if not, you will be compounding duplicate entries.
The text was updated successfully, but these errors were encountered: