Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should transactionalReadAsync use async retries? #32

Open
wernst opened this issue Mar 6, 2024 · 1 comment
Open

Should transactionalReadAsync use async retries? #32

wernst opened this issue Mar 6, 2024 · 1 comment

Comments

@wernst
Copy link
Contributor

wernst commented Mar 6, 2024

Was looking through the codebase and saw that transactionalReadAsync is using a sync retry (and potentially not awaiting the async tx.commit call). Should that be async?

If so happy to put out a quick PR.

Line for reference:

return retry(retries, () => {

@ccorcos
Copy link
Owner

ccorcos commented Mar 7, 2024

absolutely a bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants