Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add files without testing them #96

Open
langner opened this issue Oct 24, 2018 · 0 comments
Open

Ability to add files without testing them #96

langner opened this issue Oct 24, 2018 · 0 comments

Comments

@langner
Copy link
Member

langner commented Oct 24, 2018

It's common to add a regression file to this repo, and then write a regression test in the main repo at the same time. I feel like this process could be better, since we often just say "this needs to go in first" on one PR. Usually that's the data file, since the file is needed in the regression test itself.

Perhaps the right thing to do is move regressionfiles.txt to the main repo and not error out on missing files (or if there are less than N), so that here we just add files. Or maybe we just get rid of this file altogether, and track things in a different, smoother process. There needs to be a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant