Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete link handler (from Child) #57

Open
cch5ng opened this issue Mar 28, 2017 · 3 comments
Open

delete link handler (from Child) #57

cch5ng opened this issue Mar 28, 2017 · 3 comments
Labels
bug

Comments

@cch5ng
Copy link
Owner

cch5ng commented Mar 28, 2017

this shows in new menu but functionality missing
(it should be dupe of logic from the existing delete link on Favorites view)
cch5ng added a commit that referenced this issue Mar 30, 2017
@cch5ng
fix: #57; add handleRemoveList() click handler for delete from child
edff5ac
cch5ng added a commit that referenced this issue Mar 30, 2017
@cch5ng
fix: #57; cleanup
95c4f95
@cch5ng cch5ng closed this as completed in d0ad3f1 Mar 30, 2017
@cch5ng
Copy link
Owner Author

cch5ng commented Mar 30, 2017

ref:

https://github.com/ReactTraining/history#properties

@cch5ng
Copy link
Owner Author

cch5ng commented Mar 30, 2017 •
edited
Loading

child line 211 (window.location.reload()) fails on surge
(think something to do with routing works differently there)

try using Redirect comp with additional state flag like {isDeleted: bool}
https://reacttraining.com/react-router/web/example/auth-workflow

@cch5ng cch5ng reopened this Mar 30, 2017
@cch5ng cch5ng added the bug label Mar 30, 2017
@cch5ng
Copy link
Owner Author

cch5ng commented Mar 30, 2017

res:

https://github.com/ReactTraining/react-router/issues/ 1982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cch5ng