Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Nova #22

Open
Vlad0Crystal opened this issue May 13, 2023 · 6 comments
Open

Support for Nova #22

Vlad0Crystal opened this issue May 13, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Vlad0Crystal
Copy link

Is it possible to support this plugin? There are no conflicts, but there is a small nuisance, because players do not see custom blocks. I tested the issue with your plugin. Is it possible to fix this?
https://www.spigotmc.org/resources/nova-modding-framework-1-19-3.93648/

@Vlad0Crystal
Copy link
Author

image

@cavallium
Copy link
Owner

Do you see some errors in the server/client logs?

@ByteZ1337
Copy link

ByteZ1337 commented May 14, 2023

This issue is caused by us sending pre-serialized data for performance reasons, which leads to the packet not being picked up by Coordinates Obfuscator and thus spawning the display entity at the wrong coordinates. Not sure how fixable this is with only ProtocolLib, but the best approach would probably be to intercept any FriendlyByteBufs with the specific Packet IDs and change the fixed length coordinates in said ByteBuf.
I think ItemsAdder also sends FriendByteBufs so I'm guessing that's incompatible right now as well.

@cavallium
Copy link
Owner

cavallium commented May 14, 2023

I never thought about third-party plugins sending pre-serialized packets when I developed this plugin, I should definitely handle that packets.
Unfortunately, I am currently very busy with work and other personal projects, I don't have enough time to properly implement features like this for now.

@cavallium cavallium added enhancement New feature or request help wanted Extra attention is needed labels May 14, 2023
@Vlad0Crystal
Copy link
Author

Are there any options, for example, to add support for a fee? I could pay for

@cavallium
Copy link
Owner

Unfortunately I have a full-time job and I don't have time to dedicate to it, even if you pay me.
Maybe there are some other developers here that are ok with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants