Sync icon pack broken when color theme is changed via UI

[younishd]

When I change the color theme via the color theme selector the icon pack sync doesn't work as expected. It looks like the syncToIconPack() function gets called "too early" and still sees the previous theme instead of the current theme. You can see in the screen recording that the icon theme is always set to whatever the previous color theme was.

Screen.Recording.2024-08-22.at.12.11.33.mp4

On second thought this might be a VS Code limitation since we are listening on window.onDidChangeActiveColorTheme and one would probably expect that it is safe to fetch the new value after this event was fired. Perhaps VS Code changes the view and fires the event, before writing back the config? Could it be related to this recent change?

It is also worth noting that this doesn't happen if I edit the settings.json immediately.

[younishd]

I've proposed a fix in #431