-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(home-manager): add support for zed-editor #359
base: main
Are you sure you want to change the base?
Conversation
Thank you very much for working on this. This works for me: {
programs.zed-editor = {
enable = true;
userSettings = {
theme = {
dark = lib.mkForce "Catppuccin Macchiato";
};
};
};
} |
Happy to see it working! I'm just working on a way to keep compatibility with 24.05... or just give up and wait for 24.11 to release 😆 |
Probably isn't my place to comment but does this implementation take the accent/flavour combinations from the GitHub release? We actually publish all the different accents on GitHub release but not via the editor iirc. |
Currently no. We use the extension from the official repos. We likely could support that use case however! |
I actually need to understand again why we didn't publish them all via the editor, perhaps @tecandrew can explain that again (and subsequently document that reason somewhere if still valid) |
iirc, it was discussed on the Discord. I just made the decision to not flood the list of themes on a user's Zed editor instance with each Flavor when they download the Catppuccin extension Screen_Recording_2024-04-01_at_4.54.32_PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
I'd also like to use the GitHub release as mentioned above. Not sure how good of an idea that is in practice though (as I have still yet to use Zed), so totally up to you |
I'm noticing now if we wanted that we would need the ability to fetch release artifacts, or to start work on in house derivations. |
f52d2fc
to
a12c71d
Compare
a12c71d
to
1eba317
Compare
closes #317