Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager): add support for zed-editor #359

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isabelroses
Copy link
Member

closes #317

@isabelroses isabelroses marked this pull request as draft October 26, 2024 14:51
@bbigras
Copy link

bbigras commented Nov 1, 2024

Thank you very much for working on this. This works for me:

{
  programs.zed-editor = {
    enable = true;
    userSettings = {
      theme = {
        dark = lib.mkForce "Catppuccin Macchiato";
      };
    };
  };
}

@isabelroses
Copy link
Member Author

Thank you very much for working on this. This works for me:

{
  programs.zed-editor = {
    enable = true;
    userSettings = {
      theme = {
        dark = lib.mkForce "Catppuccin Macchiato";
      };
    };
  };
}

Happy to see it working! I'm just working on a way to keep compatibility with 24.05... or just give up and wait for 24.11 to release 😆

@sgoudham
Copy link
Contributor

sgoudham commented Nov 1, 2024

Probably isn't my place to comment but does this implementation take the accent/flavour combinations from the GitHub release? We actually publish all the different accents on GitHub release but not via the editor iirc.

@isabelroses
Copy link
Member Author

Probably isn't my place to comment but does this implementation take the accent/flavour combinations from the GitHub release? We actually publish all the different accents on GitHub release but not via the editor iirc.

Currently no. We use the extension from the official repos. We likely could support that use case however!

@sgoudham
Copy link
Contributor

sgoudham commented Nov 1, 2024

I actually need to understand again why we didn't publish them all via the editor, perhaps @tecandrew can explain that again (and subsequently document that reason somewhere if still valid)

@tecandrew
Copy link

iirc, it was discussed on the Discord. I just made the decision to not flood the list of themes on a user's Zed editor instance with each Flavor when they download the Catppuccin extension

Screen_Recording_2024-04-01_at_4.54.32_PM.mov

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

modules/home-manager/zed-editor.nix Outdated Show resolved Hide resolved
modules/home-manager/zed-editor.nix Outdated Show resolved Hide resolved
@getchoo
Copy link
Member

getchoo commented Nov 9, 2024

I'd also like to use the GitHub release as mentioned above. Not sure how good of an idea that is in practice though (as I have still yet to use Zed), so totally up to you

@isabelroses
Copy link
Member Author

isabelroses commented Nov 9, 2024

I'd also like to use the GitHub release as mentioned above. Not sure how good of an idea that is in practice though (as I have still yet to use Zed), so totally up to you

I'm noticing now if we wanted that we would need the ability to fetch release artifacts, or to start work on in house derivations.

@isabelroses isabelroses added the blocked Waiting on external changes label Nov 9, 2024
@isabelroses isabelroses force-pushed the home-manager/zed-editor/init branch from f52d2fc to a12c71d Compare November 9, 2024 11:43
@getchoo getchoo added this to the 2.0.0 milestone Nov 27, 2024
@isabelroses isabelroses force-pushed the home-manager/zed-editor/init branch from a12c71d to 1eba317 Compare November 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on external changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for zed-editor
5 participants