-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit flow for CI and standalone run #63
base: master
Are you sure you want to change the base?
Conversation
yes, that's a good idea. |
@vborchsh where is the screen width and indent configured? |
I've added line length=120 for example. About indents - I'm not sure, flack8/black formatters are uncompromising here... But for me it's completely fine. Less settings - less pain. |
The problem with this PR is that the contributions will not be shown correctly anymore on Github. One would have to make a separate script that calculates contributions by not taking into account this commit. I would wait with this commit until this script is added, because I don't want to take away the visibility of contributions from other people. But we can already add a commit hook that is active for new changes only - if that is possible. |
The commits statistic will be fine. The only issue is addition/deletions statistic right? And the later you do the worse it will :) Btw github has no option to exclude commits from contributors statistic, so I see no outs. Anyway, its up to you. Let's wait for possible workaround or fixes of this issue. |
Yes Github cannot do it, other projects therefore of a separate file that how much each user contributed, for example this |
Also, you can expand this file: https://github.com/vborchsh/py3gpp/blob/master/pyproject.toml (authors) in automatic way |
More contributors are here and I bring pre-commit formatter to CI to keep code in the same style. I think this might be useful for such a project. But we need to format WHOLE THE CODE.
So, I decided to leave this responsibility to @catkira as an owner and main contributor :) From my point it's better to include formatting as early as possible, otherwise it will be more and more painful.
I see several steps:
pre-commit run -a
1.1 There are several
exclude
folders, and they won't affectedpre-commit
CI hooks works fineI checked all of them, but we need to check hat everything is smooth in the main repo (here).
PS. The exact rules is point for discussion or modification. I've bring more or less default styles partially from
cocotb
CI flow.