Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing Telemetry PR comment when new telemetry is executed #48

Open
guitarrapc opened this issue Sep 21, 2023 · 1 comment · May be fixed by #51
Open

Reuse existing Telemetry PR comment when new telemetry is executed #48

guitarrapc opened this issue Sep 21, 2023 · 1 comment · May be fixed by #51
Labels
enhancement New feature or request

Comments

@guitarrapc
Copy link

Descrition of Issue

When comment_on_pr is true, action post telemetry result to PR comment. This is great feature. However it may bother PR because action post new PR comment for each new commit to PR.

Is there any plant to make it better with PR comment?

Expected behaviour

I think there are 2 method, which is often selected by other PR comment OSS.

  1. Reuse existing PR Comment if exisiting.
  2. Add new PR comment, but hide when old comment is existing.

Actual behaviour

Telemetry PR comment is posted for each new commit on PR.

image
image
image

Environment

  • OS: ubuntu-latest (=ubuntu-22.04)
  • Actions version: unforesight/workflow-telemetry-action@v1
@bojanrajh bojanrajh linked a pull request Nov 9, 2023 that will close this issue
@serkan-ozal
Copy link
Member

Hi @guitarrapc,

Thanks for your contribution, I have added a comment to your PR.

@serkan-ozal serkan-ozal added the enhancement New feature or request label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants