restore public status of NWBMetaDataEncoder encoder
#1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
support_datetime_on_conversion_options
to
main
November 14, 2024 13:47
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 129 129
Lines 8186 8182 -4
=======================================
- Hits 7424 7421 -3
+ Misses 762 761 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
h-mayorquin
commented
Nov 25, 2024
| This encoder extends the default JSONEncoder class and provides custom serialization | ||
| for certain data types commonly used in NWB metadata. | ||
| """ | ||
| class _GenericNeuroconvEncoder(json.JSONEncoder): |
There was a problem hiding this comment.
@bendichter here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1141.
I want to do this after #1139 to minimize conflict errors. This PR has #1139 as base.