Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add week long session #18

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Add week long session #18

merged 6 commits into from
Nov 25, 2024

Conversation

alessandratrapani
Copy link
Collaborator

Add multi .edf file interface and code for handling week-long session conversion

In next PRs I am going to add cell registration and a table to store start and stop time of each "sub-session"

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you remind me what is the purpose of this? I think I lost track of something in the discussion. Are we adding a conversion script per session plus one that has all EDF data? was this a request from the lab?

I am asking this because maybe I am able to offer a better review if I know the intention.

@alessandratrapani
Copy link
Collaborator Author

This looks good to me. Can you remind me what is the purpose of this? I think I lost track of something in the discussion. Are we adding a conversion script per session plus one that has all EDF data? was this a request from the lab?

I would rather separate the conversion script for the week session because it substantially differs from the script to convert the single "sub-session". This week-long session nwb file contains all the edf data recorded over the experimental week (the "sub-session" nwbfile contains only the portion of the edf data comprised in the time range of the miniscope recording of that specific sub-session), the cell registration output (#19) and the interval of the sub-session in an epoch table (#20) with the time reference being the start of the edf data recording.

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-mayorquin
Copy link
Collaborator

This looks good to me. Can you remind me what is the purpose of this? I think I lost track of something in the discussion. Are we adding a conversion script per session plus one that has all EDF data? was this a request from the lab?

I would rather separate the conversion script for the week session because it substantially differs from the script to convert the single "sub-session". This week-long session nwb file contains all the edf data recorded over the experimental week (the "sub-session" nwbfile contains only the portion of the edf data comprised in the time range of the miniscope recording of that specific sub-session), the cell registration output (#19) and the interval of the sub-session in an epoch table (#20) with the time reference being the start of the edf data recording.

Thanks for the reminder. This makes sense. I did some edits to the to-do list issue so I can remember this better.

@alessandratrapani alessandratrapani merged commit 39dd205 into main Nov 25, 2024
@alessandratrapani alessandratrapani deleted the add_week_long_session branch November 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants