Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix burnt vegetation hiding deep pits under ash piles #3163

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Bugfixes "Set burnt vegetation map extra to not leave deep pits hidden under ash piles"

Purpose of change

Another obscure side effect of the PR that allows dirt to be blown into craters I overlooked, there's another map extra in the code that relies on bashing terrain that should be leaving shallow pits at most, not deep pits.

Describe the solution

In map_extras.cpp, updated burned_ground_parser so that burnt vegetation checks for deep pits created by wrecking the ground when it creates ash piles, and converts them back to shallow pits. Mainly good because the ash furniture looks odd and in UDP it obscures the pit in a way that might lead to players blundering into one.

Left the section that doesn't place ash piles untouched, since main goal is preventing concealed deep pits, a few open pits being left seems okay to me.

Describe alternatives you've considered

Reverting neat craters because I keep finding obscure side effects.

Testing

  1. Compiled and load-tested.
  2. Spawned in after temporarily forcing burnt ground to be more commonplace for testing.
  3. Confirmed there were no deep pits under ash piles.
  4. Checked affected file for astyle.

Additional context

image

@scarf005 scarf005 self-requested a review September 16, 2023 23:44
@github-actions github-actions bot added the src changes related to source code. label Sep 17, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

left: after
right: before

pits are correctly turned into shallow ones.

@scarf005 scarf005 merged commit 7db38c2 into cataclysmbnteam:upload Sep 17, 2023
@chaosvolt chaosvolt deleted the more-pit-fixes branch September 17, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants