Fix burnt vegetation hiding deep pits under ash piles #3163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Set burnt vegetation map extra to not leave deep pits hidden under ash piles"
Purpose of change
Another obscure side effect of the PR that allows dirt to be blown into craters I overlooked, there's another map extra in the code that relies on bashing terrain that should be leaving shallow pits at most, not deep pits.
Describe the solution
In map_extras.cpp, updated
burned_ground_parser
so that burnt vegetation checks for deep pits created by wrecking the ground when it creates ash piles, and converts them back to shallow pits. Mainly good because the ash furniture looks odd and in UDP it obscures the pit in a way that might lead to players blundering into one.Left the section that doesn't place ash piles untouched, since main goal is preventing concealed deep pits, a few open pits being left seems okay to me.
Describe alternatives you've considered
Reverting neat craters because I keep finding obscure side effects.
Testing
Additional context