Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust soil from digging to match construction needs #3161

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Sep 16, 2023

Summary

SUMMARY: Balance "Increase soil yield from digging back up to an amount more in line with construction demand, belated sanity-checking for bashing rammed earth walls"

Purpose of change

When I sanity-checked digging I also reduced how much soil is produced by digging, but I'd overtuned it quite a bit compared to how much soil is used in the construction recipes I'd touched shortly before that.

Along the way, Royalfox on the BN discord pointed out that I forgot to adjust how much soil rammed earth walls give when smashed too, making them give more than they take to make.

Describe the solution

  1. In iuse.cpp, changed digging_moves_and_byproducts so that it produces a total of 600 liters of material when excavated, for a maximum of 120 soil per deep pit. This works with rammed earth walls taking 100 soil and earthbag walls taking 108 soil.
  2. Set rammed earth walls to give 50-75 soil when bashed.

Describe alternatives you've considered

Reducing soil demand in construction even more instead.

Testing

  1. Compiled and load-tested.
  2. Dug a deep pit, confirmed that it spawned over 100 soil altogether.

Additional context

Side note, boulders got a buff to how much stone they produce but solid rock didn't, I'll likely open another PR aimed towards giving a similar parity to obtaining rocks for stone walls.

@github-actions github-actions bot added the src changes related to source code. label Sep 16, 2023
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Sep 16, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Firestorm01X2 Firestorm01X2 merged commit f966f7f into cataclysmbnteam:upload Sep 16, 2023
17 of 18 checks passed
@chaosvolt chaosvolt deleted the soil-is-smol branch September 16, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants