From 090669b83dbf9659f6a04b0fff089ac3093c4bb2 Mon Sep 17 00:00:00 2001 From: scarf Date: Mon, 11 Sep 2023 09:20:24 +0900 Subject: [PATCH 1/2] fix: `open_url` not working on windows --- src/url_utility.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/url_utility.cpp b/src/url_utility.cpp index 688b340658cb..be1fb532157c 100644 --- a/src/url_utility.cpp +++ b/src/url_utility.cpp @@ -8,10 +8,8 @@ void open_url( const std::string &url ) { static const std::string executable = -#if defined(_WIN32) - "explorer"; -#elif defined(_WIN64) - "start"; +#if defined(_WIN32) || defined(_WIN64) + "start \"\""; #elif defined(__linux__) "xdg-open"; #elif defined(__APPLE__) From ac8f52abe95c9986a42410f7e52e95695d434dbc Mon Sep 17 00:00:00 2001 From: scarf Date: Mon, 11 Sep 2023 23:28:06 +0900 Subject: [PATCH 2/2] Update src/url_utility.cpp Co-authored-by: Olanti --- src/url_utility.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/url_utility.cpp b/src/url_utility.cpp index be1fb532157c..6ae3682f3121 100644 --- a/src/url_utility.cpp +++ b/src/url_utility.cpp @@ -8,7 +8,7 @@ void open_url( const std::string &url ) { static const std::string executable = -#if defined(_WIN32) || defined(_WIN64) +#if defined(_WIN32) "start \"\""; #elif defined(__linux__) "xdg-open";